handling Receive Packet Frame added#56
Merged
jamesleesaunders merged 2 commits intoniolabs:masterfrom Sep 20, 2017
Merged
Conversation
jamesleesaunders
requested changes
Sep 20, 2017
Collaborator
jamesleesaunders
left a comment
There was a problem hiding this comment.
Thank you for contributing! I have a question about the name and options you have chosen for this additional frame type.
| 'structure':[ | ||
| {'name': 'source_addr_long', 'len':8}, | ||
| {'name': 'source_addr', 'len':2}, | ||
| {'name': 'rec_options', 'len':1}, |
Collaborator
There was a problem hiding this comment.
Rather than:
'name': 'receive_packet',
...
{'name': 'rec_options', 'len':1},
Should this be:
'name': 'rx',
...
{'name': 'options', 'len':1},
The name and options? This then matches this packet type (\x90) in other implementations, for example:
python-xbee/xbee/backend/zigbee.py
Line 114 in 5643255
and:
python-xbee/xbee/backend/digimesh.py
Line 109 in 5643255
Contributor
Author
|
tnx for your suggestion, I edited the names. |
Collaborator
|
Cool thanks @PoOyaKhandel, thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with this changes, receive packet frames from xbee are known and handled.