Skip to content

handling Receive Packet Frame added#56

Merged
jamesleesaunders merged 2 commits intoniolabs:masterfrom
po-oya:master
Sep 20, 2017
Merged

handling Receive Packet Frame added#56
jamesleesaunders merged 2 commits intoniolabs:masterfrom
po-oya:master

Conversation

@po-oya
Copy link
Copy Markdown
Contributor

@po-oya po-oya commented Sep 19, 2017

with this changes, receive packet frames from xbee are known and handled.

Copy link
Copy Markdown
Collaborator

@jamesleesaunders jamesleesaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I have a question about the name and options you have chosen for this additional frame type.

Comment thread xbee/backend/ieee.py Outdated
'structure':[
{'name': 'source_addr_long', 'len':8},
{'name': 'source_addr', 'len':2},
{'name': 'rec_options', 'len':1},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than:

'name': 'receive_packet',
...
{'name': 'rec_options',         'len':1},

Should this be:

'name': 'rx',
...
{'name': 'options',         'len':1},

The name and options? This then matches this packet type (\x90) in other implementations, for example:


and:

@po-oya
Copy link
Copy Markdown
Contributor Author

po-oya commented Sep 20, 2017

tnx for your suggestion, I edited the names.

@jamesleesaunders
Copy link
Copy Markdown
Collaborator

Cool thanks @PoOyaKhandel, thank you for contributing!

@jamesleesaunders jamesleesaunders merged commit 44a29dc into niolabs:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants