Skip to content

Conversation

@eilidhmacnicol
Copy link
Collaborator

Fixes #21 with implementation from the new niworkflows tools( nipreps/niworkflows#511 )

Whether any other problems emerge remain to be seen...

@eilidhmacnicol eilidhmacnicol requested a review from oesteban May 6, 2020 23:41
@pull-assistant
Copy link

pull-assistant bot commented May 6, 2020

Score: 0.89

Best reviewed: commit by commit


Optimal code review plan (2 commits squashed)

     FIX: resampling bug

FIX: explicit in an... ... FIX: remove compatib...

Squashed 2 commits:

Powered by Pull Assistant. Last update 35c902c ... b637860. Read the comment docs.

@eilidhmacnicol
Copy link
Collaborator Author

Latest commit addresses symptoms in antsAI but not cause.

call for _ants_version was not setting search_grid parameters for antsAI, so have explicitly included them because without them initial affine stage is rubbish. Worth having a conversation about fixing it or whether NiRodents just requires ants >= 2.3.0

@eilidhmacnicol eilidhmacnicol mentioned this pull request May 8, 2020
@oesteban oesteban merged commit 15b9fa5 into master May 10, 2020
@eilidhmacnicol eilidhmacnicol deleted the fix/resample_bug branch May 11, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResampleImageBySpacing unintended outputs

3 participants