Skip to content

Conversation

@eilidhmacnicol
Copy link
Collaborator

Overhaul of the workflow section to reduce unnecessary repeats of code. Fixed code now allows artsBrainExtraction to run from the command line without errors.

Requires #22 to be merged first since this includes changes from that branch.

@eilidhmacnicol eilidhmacnicol requested a review from oesteban May 8, 2020 18:42
@pull-assistant
Copy link

pull-assistant bot commented May 8, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     MAIN: workflow tidying

     FIX: correct TemplateFlow mask call

Powered by Pull Assistant. Last update 658debc ... 266fdc0. Read the comment docs.

@eilidhmacnicol eilidhmacnicol changed the title Main/tidy workflows MAIN: tidy workflow May 8, 2020
@oesteban oesteban force-pushed the main/tidy_workflows branch from e3f2696 to 2257fa3 Compare May 10, 2020 04:20
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick first pass

eilidhmacnicol and others added 2 commits May 11, 2020 09:23
Corrects version of mask called for template registration mask
@oesteban oesteban force-pushed the main/tidy_workflows branch from 7094792 to 266fdc0 Compare May 11, 2020 16:28
@pep8speaks
Copy link

Hello @eilidhmacnicol! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 65:100: E501 line too long (111 > 99 characters)
Line 199:5: E265 block comment should start with '# '
Line 200:5: E265 block comment should start with '# '
Line 233:5: E265 block comment should start with '# '
Line 259:9: E265 block comment should start with '# '
Line 279:9: E265 block comment should start with '# '
Line 284:9: E265 block comment should start with '# '

@oesteban oesteban merged commit 1696683 into master May 11, 2020
@oesteban oesteban deleted the main/tidy_workflows branch May 11, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants