FIX: Correctly pin niworkflows branch and use new interface #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
oesteban
commented
May 10, 2020
| import os | ||
| from multiprocessing import cpu_count | ||
| from pkg_resources import resource_filename as pkgr_fn | ||
| from packaging.version import parse as parseversion, Version |
Member
Author
There was a problem hiding this comment.
cleaning up some stuff that is not ever used anymore
| # niworkflows | ||
| from niworkflows.interfaces.ants import ImageMath | ||
| from niworkflows.utils.images import resample_by_spacing | ||
| from niworkflows.interfaces.images import RegridToZooms |
Member
Author
There was a problem hiding this comment.
this is the new interface
setup.cfg
Outdated
| nipype @ git+https://github.com/nipy/nipype.git@master | ||
| niworkflows @ git+https://github.com/nipreps/niworkflows.git@master | ||
| templateflow >= 0.5.2 | ||
| niworkflows @ git+https://github.com/oesteban/niworkflows.git@enh/resample-interface |
Member
Author
There was a problem hiding this comment.
this is the right way of pinning the new branch
oesteban
force-pushed
the
enh/use-niworkflows-interface
branch
from
91d9b41 to
1ddc0c1
Compare
oesteban
added a commit
that referenced
this pull request
May 11, 2020
tidying up for consistency
eilidhmacnicol
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there is a fully-fledged nipype interface for the resampling. Here I just switch to that.