ENH: Setup a smoke test on CircleCI + minor improvements to CLI #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
oesteban
commented
May 11, 2020
Comment on lines
134
to
136
| docker run -u $( id -u ) --rm -it -v /tmp/templateflow:/home/nirodents/.cache/templateflow \ | ||
| $PWD/nirodents/data:/data -v /tmp/workdir:/work -w /work nirodents:latest \ | ||
| artsBrainExtraction /data/15_1_T2_Quick_RAS.nii.gz --sloppy |
Member
Author
There was a problem hiding this comment.
this adds a smoke test on the example dataset.
oesteban
force-pushed
the
enh/revise-workflow
branch
from
0207f95 to
6dc1416
Compare
oesteban
force-pushed
the
enh/revise-workflow
branch
from
6dc1416 to
f4e1de8
Compare
| default=False, | ||
| help="Use low-quality tools for speed - TESTING ONLY", | ||
| ) | ||
| return parser |
Collaborator
There was a problem hiding this comment.
Should we also have an argument for modality? T2w or mp2rage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #25 first.