Skip to content

feat: improve LoadSequence component#14

Merged
nipsysdev merged 2 commits intomainfrom
feature/better_load_sequence
Jul 10, 2025
Merged

feat: improve LoadSequence component#14
nipsysdev merged 2 commits intomainfrom
feature/better_load_sequence

Conversation

@nipsysdev
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 10, 2025 21:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors and enhances the LoadSequence component by adding static initial steps, extracting shared styling, and updating animations and tests.

  • Introduces two static HTML steps (Connected to IPFS, Loading core chunks) rendered immediately with custom keyframes.
  • Refactors the dynamic step array: removes Typography, extracts fadeInAnimation and stepHeight constants, adjusts delays, and replaces Typography with <div>.
  • Imports a new globals.css with keyframe definitions and updates snapshots/tests to match the new load sequence.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/components/tests/snapshots/LoadSequence.test.tsx.snap Updated snapshot with new static steps and updated container classes
src/components/tests/LoadSequence.test.tsx Changed expected text from > Connection initialized to > Detecting user locale...
src/components/LoadSequence.tsx Refactored component: added static steps, styling constants, and updated dynamic steps rendering
src/app/layout.tsx Imported globals.css for new keyframe animations
src/app/globals.css Defined fadeIn and showInstant keyframes
Comments suppressed due to low confidence (1)

src/components/LoadSequence.tsx:53

  • [nitpick] The constant fadeInAnimation actually references the showInstant keyframes—consider renaming it to showInstantAnimation for clarity.
  const fadeInAnimation =

Comment thread src/app/globals.css Outdated
Comment thread src/components/LoadSequence.tsx
@nipsysdev nipsysdev merged commit 0c9487d into main Jul 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants