Skip to content

Conversation

@larsoner
Copy link
Contributor

This should fix AppVeyor and make it build the docs (in noplot mode).

@coveralls
Copy link

coveralls commented Jun 25, 2017

Coverage Status

Coverage remained the same at 79.044% when pulling def2546 on Eric89GXL:appveyor into 419a93b on nipy:master.

@coveralls
Copy link

coveralls commented Jun 25, 2017

Coverage Status

Coverage remained the same at 79.044% when pulling ee43316 on Eric89GXL:appveyor into 419a93b on nipy:master.

@coveralls
Copy link

coveralls commented Jun 25, 2017

Coverage Status

Coverage remained the same at 79.044% when pulling c99d3f3 on Eric89GXL:appveyor into 419a93b on nipy:master.

@coveralls
Copy link

coveralls commented Jun 25, 2017

Coverage Status

Coverage increased (+0.02%) to 79.066% when pulling f2186eb on Eric89GXL:appveyor into 419a93b on nipy:master.

@larsoner
Copy link
Contributor Author

I'll merge this once the CIs are happy since it fixes AppVeyor

@christianbrodbeck
Copy link
Collaborator

Is reverting the mlab backend necessary to get the tests to work? It will make the tests less complete...

@larsoner
Copy link
Contributor Author

They cause AppVeyor to crash

@christianbrodbeck
Copy link
Collaborator

I see... could we make it system-dependent?

@larsoner
Copy link
Contributor Author

... they also cause windows to open locally during testing, which is less than ideal. The best thing would be to make Mayavi more fully support the test backend.

But I agree it's slightly better to cover more fully, so I'll make a commit to triage for Windows.

@christianbrodbeck
Copy link
Collaborator

Yeah I agree windows opening during testing are less than ideal... at least as it is now you can change to the test backend temporarily with one change.

@larsoner
Copy link
Contributor Author

Okay we're green so I'll squash and merge. But if people feel like looking feel free and we can iterate.

@larsoner larsoner merged commit 832e188 into nipy:master Jun 26, 2017
@larsoner larsoner deleted the appveyor branch June 26, 2017 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants