Skip to content

Conversation

@christianbrodbeck
Copy link
Collaborator

Fix for a corner case where multiple data layers are added, and not all of them have a time axis

Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 for merge

@mwaskom
Copy link
Member

mwaskom commented Jun 29, 2017

Ah I think I've hit this before and couldn't figure out why. Thanks!

@mwaskom
Copy link
Member

mwaskom commented Jun 29, 2017

Does anyone know why our travis builds are taking forever to get going lately?

@larsoner
Copy link
Contributor

larsoner commented Jun 29, 2017 via email

@mwaskom
Copy link
Member

mwaskom commented Jun 29, 2017

Is this travis failure related to these changes?

@christianbrodbeck
Copy link
Collaborator Author

Very unlikely it's form these changes because the relevant test (test_image ) never adds a data-layer. Also could not spot any changed version in the installed packages. I can't rerun the build to see whether it fails consistently, can one of you?

@mwaskom
Copy link
Member

mwaskom commented Jun 30, 2017

Kicking it to see what happens...

@christianbrodbeck
Copy link
Collaborator Author

all clear...

@mwaskom mwaskom merged commit 5176164 into nipy:master Jun 30, 2017
@christianbrodbeck christianbrodbeck deleted the fix/minor branch July 17, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants