ENH: Add annotation from arrays #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Very nice. I have a few thoughts on this, having almost implemented it several times before. I'll try to play around with it and give comments soon. |
Contributor
|
LGTM +1 for MRG when CIs are happy |
Contributor
Member
|
OK or maybe not :) |
Collaborator
Author
|
I don't mind opening a new PR if you have suggestions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been creating annotations programmatically and wanted to plot them without saving them to a file first. The change simply allows providing the output of the file read operation directly, most of the changed lines are just due to indentation.