Skip to content

Write command arguments as lists of strings instead of splitting strings on whitespace #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2023
Merged

Write command arguments as lists of strings instead of splitting strings on whitespace #664

merged 1 commit into from
Apr 12, 2023

Conversation

@jwodder
Copy link
Contributor

@jwodder jwodder commented Apr 10, 2023 •
edited
Loading

No description provided.

@jwodder jwodder changed the title Presplit args Write command arguments as lists of strings instead of splitting strings on whitespace Apr 10, 2023
@jwodder jwodder added the internal Changes only affect the internal API label Apr 10, 2023
@jwodder jwodder marked this pull request as ready for review April 10, 2023 16:39
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Patch coverage: 77.27% and project coverage change: +0.02 🎉

Comparison is base (012895d) 81.22% compared to head (956e1f4) 81.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   81.22%   81.24%   +0.02%     
==========================================
  Files          43       43              
  Lines        3925     3924       -1     
==========================================
  Hits         3188     3188              
+ Misses        737      736       -1
Impacted Files Coverage Δ
heudiconv/cli/monitor.py 31.86% <28.57%> (+1.09%) ⬆️
heudiconv/tests/test_convert.py 100.00% <100.00%> (ø)
heudiconv/tests/test_heuristics.py 100.00% <100.00%> (ø)
heudiconv/tests/test_main.py 100.00% <100.00%> (ø)
heudiconv/tests/test_queue.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

yarikoptic
yarikoptic approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

@jwodder
Copy link
Contributor Author

jwodder commented Apr 11, 2023

@yarikoptic Conflicts resolved.

@yarikoptic yarikoptic merged commit 5a12d0b into master Apr 12, 2023
@yarikoptic yarikoptic deleted the presplit-args branch April 12, 2023 03:28
@github-actions
Copy link

github-actions bot commented May 8, 2023

🚀 PR was released in v0.13.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yarikoptic yarikoptic yarikoptic approved these changes

Assignees

No one assigned

Labels

internal Changes only affect the internal API released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwodder @yarikoptic