ENH WIP added applyxfm4d #1459
ENH WIP added applyxfm4d #1459
Conversation
| class ApplyXfm4DInputSpec(FSLCommandInputSpec): | ||
| in_file = File(exists=True, position=0, argstr='%s', mandatory=True, desc="timeseries to motion-correct") | ||
| ref_vol = File(exists=True, position=1, argstr='%s', mandatory=True, desc="volume with final FOV and resolution") | ||
| out_file = File(exists=True, position=2, argstr='%s', genfile=True, desc="file to write", hash_files=False) |
There was a problem hiding this comment.
i think this one shouldn't have exists=True and should also have hash_files=False so that out_file doesn't get hashed if it exists.
i think the logic of this interface can be simplified greatly by using name_source and name_template
http://nipype.readthedocs.org/en/latest/devel/cmd_interface_devel.html#creating-outputs-on-the-fly
|
@ostanley - any chance you can address the issues? |
|
@ostanley thanks for the PR, did you have time to try Satra suggestions? Are you still planning to work on it? |
|
@ostanley - please let us know if you're planning to finish this PR or need some help, otherwise I'll try to review and finish it. |
|
This pull request is "orphaned," which means it has been deemed to be abandoned by its original author. Orphaned pull requests have not been rejected, and we hope that if a user sees one that will meet their needs with a little work, that they will fork it and open a new pull request (or, in the case of the original author, reopen the original PR). We ask that all adopted PRs be updated to merge or rebase the current master. If you would like to adopt a PR and need help getting started, any of a number of contributors will be happy to help. |
4 participants
Added wrapper for fsl command line tool, applyxfm4D. Currently investigating errors in
make check-before-commitand will update after resolution.