Only allocate frameData for content length, not more is needed. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @ened , thanks for your contribution! |
Owner
|
@ened is this PR still valid or I can close it? |
hannesa2
reviewed
Mar 28, 2021
|
|
||
| private int getEndOfSeqeunceSimplified(DataInputStream in, byte[] sequence) | ||
| throws IOException { | ||
| private int getEndOfSeqeunceSimplified(DataInputStream in, byte[] sequence) throws IOException { |
Contributor
There was a problem hiding this comment.
@niqdev
It's out of this pull request, but I guess you need some codestyle settings here, to avoid that much non-logic changes
Contributor
Author
Still valid as it has not been integrated I think. |
Contributor
|
@ened |
Owner
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately also includes a few formatting nits. Hope it keeps the PR readable.