Ensure optional type include None type#106
Merged
dahlia merged 1 commit intonirum-lang:maintenance-0.6from Jan 8, 2018
Merged
Conversation
dahlia
reviewed
Jan 8, 2018
CHANGES.rst
Outdated
|
|
||
| To be released. | ||
|
|
||
| - Added ``is_optional_type`` to ensure optional type includes ``None`` type. |
Member
There was a problem hiding this comment.
is_optional_type() would be better.
kanghyojun
force-pushed
the
test-optional-type
branch
from
e53a7cd to
2f85525
Compare
dahlia
approved these changes
Jan 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only Union type used in nirum-python is optional type . that is why
deserialize_metacould work well, even though we useis_union_typeto find optional type.But comment from other pull request suggest adding
is_optional_typeto ensureNoneis in it.After we release nirum 0.6.2, replace
nirum._compat.is_optional_typeintonirum_wsgi.is_optional_type.