New class and facility CallSiteBuilder#2849
Merged
privat merged 6 commits intonitlang:masterfrom Aug 19, 2024
Merged
Conversation
Test Results 67 files 338 suites 17m 40s ⏱️ Results for commit 1091127. ♻️ This comment has been updated with latest results. |
Signed-off-by: Jean Privat <jean@pryen.org>
…TypeVisitor) Signed-off-by: Jean Privat <jean@pryen.org>
Signed-off-by: Jean Privat <jean@pryen.org>
Signed-off-by: Jean Privat <jean@pryen.org>
Signed-off-by: Jean Privat <jean@pryen.org>
Signed-off-by: Jean Privat <jean@pryen.org>
privat
force-pushed
the
callsitebuilder
branch
from
ab304a8 to
1091127
Compare
dullin
reviewed
Aug 19, 2024
| # Helper class to build a callsite object with a fluent API | ||
| class CallSiteBuilder | ||
| var location: Location | ||
| var recv: MType |
Contributor
There was a problem hiding this comment.
recv is called recvtype in the ASTBuilder Builder. Might want to have the same name. recvtype is used in many other places for types. recv is often used for an AExpr. Might want to refactor the Callsite builder to have recvtype instead of recv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, a helper interface,
TypeContext, is extracted fromTypeVisitorThen
CallSiteBuilderis created and used.