Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix(cli): remove non-existent /dev from Dashboard URL#74

Merged
jyecusch merged 2 commits into
mainfrom
fix-dev-url
Sep 24, 2025
Merged

fix(cli): remove non-existent /dev from Dashboard URL#74
jyecusch merged 2 commits into
mainfrom
fix-dev-url

Conversation

@tjholm
Copy link
Copy Markdown
Member

@tjholm tjholm commented Sep 19, 2025

Fixes: NIT-278

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 19, 2025

Walkthrough

Removed the Dashboard field from the CLI simulation startup output; the SugaIntro now prints only App and Addr (the prior use of version.ProductURL with "/dev" was dropped and the version import removed). Documentation updates in docs/introduction.mdx and docs/quickstart.mdx replace https://app.addsuga.com/dev with https://app.addsuga.com. No changes to logic, error handling, control flow, or exported/public interfaces.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "fix(cli): remove non-existent /dev from Dashboard URL" succinctly and accurately summarizes the main change — removal of the "/dev" segment from the Dashboard URL in the CLI output and docs (see cli/internal/simulation/simulation.go and docs/*.mdx). It is specific, concise, and appropriate for scanning change history.
Description Check ✅ Passed The description "Fixes: NIT-278" directly ties the PR to the tracked issue that this changeset addresses and is therefore on-topic, though minimal. It meets this lenient check's requirement.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
cli/internal/simulation/simulation.go (1)

86-86: Remove unnecessary fmt.Sprintf wrapper.

The static analysis correctly identifies that version.ProductURL is already a string, so wrapping it in fmt.Sprintf is redundant.

Apply this diff to fix the linting issue:

-	fmt.Println(tui.SugaIntro("App", s.appSpec.Name, "Addr", addr, "Dashboard", fmt.Sprintf("%s", version.ProductURL)))
+	fmt.Println(tui.SugaIntro("App", s.appSpec.Name, "Addr", addr, "Dashboard", version.ProductURL))
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce6c88 and b44ee55.

📒 Files selected for processing (3)
  • cli/internal/simulation/simulation.go (1 hunks)
  • docs/introduction.mdx (1 hunks)
  • docs/quickstart.mdx (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
cli/internal/simulation/simulation.go (2)
cli/pkg/tui/intro.go (1)
  • SugaIntro (15-33)
cli/internal/version/version.go (1)
  • ProductURL (22-22)
🪛 GitHub Check: Lint
cli/internal/simulation/simulation.go

[failure] 86-86:
S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)

🪛 GitHub Actions: Test CLI
cli/internal/simulation/simulation.go

[error] 86-86: golangci-lint: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple).

🔇 Additional comments (3)
docs/quickstart.mdx (1)

163-163: URL updated to match the current Dashboard location.

The change correctly removes the non-existent /dev path from the Dashboard URL, aligning with the actual URL structure.

docs/introduction.mdx (1)

117-117: Documentation updated to reflect correct Dashboard URL.

The change from https://app.addsuga.com/dev to https://app.addsuga.com correctly aligns the documentation with the actual Dashboard URL structure.

cli/internal/simulation/simulation.go (1)

86-86: Dashboard URL correctly updated to remove non-existent /dev path.

The change from version.ProductURL + "/dev" to version.ProductURL fixes the issue where users were being directed to a non-existent URL path. This aligns with the documentation updates and ensures users can access the actual Dashboard.

Comment thread cli/internal/simulation/simulation.go Outdated
Comment thread cli/internal/simulation/simulation.go Outdated
Comment thread docs/introduction.mdx Outdated
Comment thread docs/quickstart.mdx Outdated
@jyecusch jyecusch changed the title fix: remove non-existent /dev from Dashboard URL fix(cli): remove non-existent /dev from Dashboard URL Sep 22, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
cli/internal/simulation/simulation.go (1)

78-86: Show localhost in intro when binding to all interfaces (UX polish)

Currently prints ":" when SUGA_HOST is empty or "0.0.0.0". Prefer a click-friendly/local-friendly host in the intro while still listening on all interfaces.

 addr := net.JoinHostPort(host, s.apiPort.String())

 lis, err := net.Listen("tcp", addr)
 if err != nil {
   return fmt.Errorf("failed to listen: %v", err)
 }
 
- fmt.Println(tui.SugaIntro("App", s.appSpec.Name, "Addr", addr))
+ displayAddr := addr
+ if host == "" || host == "0.0.0.0" || host == "::" || host == "[::]" {
+   displayAddr = net.JoinHostPort("localhost", s.apiPort.String())
+ }
+ fmt.Println(tui.SugaIntro("App", s.appSpec.Name, "Addr", displayAddr))
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7902e26 and 60fc249.

📒 Files selected for processing (3)
  • cli/internal/simulation/simulation.go (1 hunks)
  • docs/introduction.mdx (0 hunks)
  • docs/quickstart.mdx (0 hunks)
💤 Files with no reviewable changes (2)
  • docs/introduction.mdx
  • docs/quickstart.mdx
🧰 Additional context used
🧬 Code graph analysis (1)
cli/internal/simulation/simulation.go (1)
cli/pkg/tui/intro.go (1)
  • SugaIntro (15-33)

Comment thread cli/internal/simulation/simulation.go
@jyecusch jyecusch merged commit 4ff0b0b into main Sep 24, 2025
5 checks passed
@jyecusch jyecusch deleted the fix-dev-url branch September 24, 2025 04:08
@nitric-bot
Copy link
Copy Markdown

🎉 This PR is included in version 0.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants