Feature/collection subcollections#38
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 95.91% 95.64% -0.27%
==========================================
Files 16 16
Lines 710 735 +25
==========================================
+ Hits 681 703 +22
- Misses 29 32 +3
Continue to review full report at Codecov.
|
jyecusch
requested changes
Sep 1, 2021
Comment on lines
+230
to
+240
| def to_collection_ref(self): | ||
| """Return this collection group as a collection ref""" | ||
| return CollectionRef( | ||
| self._documents, | ||
| self.name, | ||
| DocumentRef( | ||
| self._documents, | ||
| self.parent, | ||
| NIL_DOC_ID, | ||
| ), | ||
| ) |
Member
There was a problem hiding this comment.
I don't think we should allow this, we don't want nil doc refs floating around.
jyecusch
approved these changes
Sep 9, 2021
jyecusch
force-pushed
the
feature/collection-subcollections
branch
from
533d117 to
b59f825
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.