Skip to content

fix(cli): python client address handling#105

Merged
tjholm merged 1 commit intomainfrom
NIT-390
Oct 7, 2025
Merged

fix(cli): python client address handling#105
tjholm merged 1 commit intomainfrom
NIT-390

Conversation

@raksiv
Copy link
Member

@raksiv raksiv commented Oct 6, 2025

Ensures that the client functions correctly even if the environment variable is set to an empty value. (e.g. not set).

Ensures that the client functions correctly even if the environment variable is set to an empty value.
@raksiv raksiv self-assigned this Oct 6, 2025
@raksiv raksiv added the bug Something isn't working label Oct 6, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

📝 Walkthrough

Walkthrough

The Python client template updates SugaClient address initialization. Instead of checking address == "" to trigger the default, it now uses a truthiness check (not address). This applies the default "localhost:50051" when the address is unset, None, or an empty string, consolidating control flow into a single condition. No other areas are modified.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly states that this change fixes how the Python client handles its address configuration, which aligns directly with the core code modification.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description directly addresses the change to use a truthiness check for the address environment variable so the client defaults correctly when the variable is empty or unset, which aligns with the code modifications. It is specific to the actual behavior change and not generic or off-topic. Therefore, the description clearly relates to the changeset and meets the lenient criteria for this check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tjholm tjholm merged commit 3ddf451 into main Oct 7, 2025
13 checks passed
@tjholm tjholm deleted the NIT-390 branch October 7, 2025 05:22
@nitric-bot
Copy link

🎉 This PR is included in version 0.1.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants