Remove Debian Docker variant, consolidate to Alpine-only (#231)#244
Remove Debian Docker variant, consolidate to Alpine-only (#231)#244nitrobass24 merged 1 commit intodevelopfrom
Conversation
Drop the Debian Dockerfile and promote Alpine as the single image.
This simplifies the CI pipeline from 4 matrix builds (2 variants x
2 arches) down to 2 (amd64 + arm64), removes the `-alpine` tag
suffix, and eliminates duplicate metadata steps in the publish job.
- Delete `Dockerfile` (Debian) and rename `Dockerfile.alpine` to `Dockerfile`
- Remove variant matrix from build, build-arm64, and publish CI jobs
- Simplify artifact names from `digests-{variant}-{arch}` to `digests-{arch}`
- Consolidate four metadata extraction steps into two (release + develop)
- Tags now use `latest`/`X.Y.Z`/`develop` without `-alpine` suffix
- Add BuildKit cache mount for npm ci (`--mount=type=cache,target=/root/.npm`)
- HEALTHCHECK already uses wget (Alpine-native) instead of python urllib
- Update Makefile shell target from /bin/bash to /bin/sh
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe pull request consolidates the Docker build pipeline from separate Debian and Alpine variants into a single Alpine-based approach. Changes include removing the Dockerfile.alpine file, simplifying the CI workflow by eliminating matrix strategy configurations, and optimizing the unified Dockerfile with Alpine-specific base images, caching strategies (npm cache mount), and dependency management. The shell in the Makefile dev container is switched from bash to sh. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
Drop the Debian Dockerfile and promote Alpine as the single image.
This simplifies the CI pipeline from 4 matrix builds (2 variants x
2 arches) down to 2 (amd64 + arm64), removes the `-alpine` tag
suffix, and eliminates duplicate metadata steps in the publish job.
- Delete `Dockerfile` (Debian) and rename `Dockerfile.alpine` to `Dockerfile`
- Remove variant matrix from build, build-arm64, and publish CI jobs
- Simplify artifact names from `digests-{variant}-{arch}` to `digests-{arch}`
- Consolidate four metadata extraction steps into two (release + develop)
- Tags now use `latest`/`X.Y.Z`/`develop` without `-alpine` suffix
- Add BuildKit cache mount for npm ci (`--mount=type=cache,target=/root/.npm`)
- HEALTHCHECK already uses wget (Alpine-native) instead of python urllib
- Update Makefile shell target from /bin/bash to /bin/sh
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Dockerfile.alpineand promote Alpine as the soleDockerfileshelltarget from/bin/bashto/bin/sh(Alpine uses ash)Closes #231
Test plan
make shellworks correctly with/bin/sh🤖 Generated with Claude Code
Summary by CodeRabbit