Fix parser crash: skip unrecognized lines inside job context

[nitrobass24]

Summary

Replaces the whack-a-mole approach to PTY line-wrap fragments with a single rule: skip any unrecognized line when inside a job context.

Problem

PR #290 fixed one specific fragment pattern (filename tails), but production immediately hit two new variants:

• eta:4m [Receiving data] — line wraps right before the eta value
• ta:4m [Receiving data] — line wraps mid-word in "eta"

PTY wrapping can break lines at arbitrary byte positions. No finite set of regex patterns can anticipate all possible fragments.

Fix

When prev_job is set (we're parsing lines inside a recognized job), skip any unrecognized line with a warning instead of raising. Lines outside any job context still raise to catch genuinely malformed output.

This is a safer, more general approach than adding specific patterns for each fragment type.

Tests

• test_unrecognized_line_inside_job_is_skipped — garbage inside job is skipped
• test_eta_fragment_inside_job_is_skipped — eta:4m [Receiving data]
• test_partial_eta_fragment_inside_job_is_skipped — ta:4m [Receiving data]
• test_truly_unrecognized_line_outside_job_raises — garbage with no job context still raises
• All 62 parser tests pass

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved parser resilience: unexpected fragments encountered while parsing an active job are now skipped with a warning instead of causing a failure; strict validation for truly unrecognized lines outside job contexts is preserved.

• Tests

  • Expanded unit tests to cover wrapped/fragmented progress lines and confirm skip vs. raise behavior.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7741ac0e-b7db-4a0f-b290-b1002df22dc3

📥 Commits

Reviewing files that changed from the base of the PR and between 4fe277c and 878ae49.

📒 Files selected for processing (1)

• src/python/tests/unittests/test_lftp/test_job_status_parser.py

---

📝 Walkthrough

Walkthrough

The parser now skips unrecognized lines when parsing inside an active job (prev_job != None), logging a warning instead of raising ValueError. Unrecognized lines outside any job context continue to raise errors. Tests were expanded to cover PTY-wrapped and fragmented progress-line edge cases.

Changes

Cohort / File(s)	Summary
Core Parser Logic src/python/lftp/job_status_parser.py	Adjust __parse_jobs to tolerate and skip unrecognized/fragmented lines when currently inside a parsed job (prev_job present), logging a warning; preserve error raising for unrecognized lines outside job context.
Test Suite src/python/tests/unittests/test_lftp/test_job_status_parser.py	Replace single error-test with multiple tests verifying: skipped unrecognized lines inside a job, skipped ETA and partial-ETA fragments inside a job, and that truly unrecognized lines outside a job still raise an error.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix parser crash on unrecognized lftp status lines (#253) #258 — similar change to make unrecognized lftp output non-fatal by skipping instead of raising.
• Fix parser crash on chunk line-wrap from long filenames #290 — broadens parser tolerance for PTY-wrapped/fragmented progress lines to avoid ValueErrors.
• Fix chunk parser crash, zombie app, and incomplete directory re-download #85 — earlier adjustments to chunk handling and conditional skipping in job_status_parser.py.

Suggested labels

bug

Poem

🐰 I hopped through logs with careful ears,
Skipping broken whispers, easing fears.
Inside each job I nibble stray lines clean,
Outside the bounds, I sound the warning keen.
Happy parsing — carrots for the routine!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing a parser crash by skipping unrecognized lines inside job contexts. It directly corresponds to the core modification in the code and test files.
Docstring Coverage	✅ Passed	Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/parser-skip-unrecognized-in-job

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/python/tests/unittests/test_lftp/test_job_status_parser.py`:
- Around line 1589-1621: The file test_job_status_parser.py has formatting
issues flagged by ruff; run ruff format on that test file to fix
whitespace/formatting so CI passes — e.g. format the file containing the test
methods test_unrecognized_line_inside_job_is_skipped,
test_eta_fragment_inside_job_is_skipped,
test_partial_eta_fragment_inside_job_is_skipped, and
test_truly_unrecognized_line_outside_job_raises by running `ruff format` (or
your editor’s ruff integration) on
src/python/tests/unittests/test_lftp/test_job_status_parser.py, then re-run
tests/CI.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a2c0480-108a-4b1f-a071-8bd2ee6d920c

📥 Commits

Reviewing files that changed from the base of the PR and between 0e19eb5 and 4fe277c.

📒 Files selected for processing (2)

• src/python/lftp/job_status_parser.py
• src/python/tests/unittests/test_lftp/test_job_status_parser.py