Skip to content

PR 11: E2E — Settings Coverage Expansion#442

Merged
nitrobass24 merged 5 commits into
developfrom
test/e2e-settings-expansion
May 2, 2026
Merged

PR 11: E2E — Settings Coverage Expansion#442
nitrobass24 merged 5 commits into
developfrom
test/e2e-settings-expansion

Conversation

@nitrobass24
Copy link
Copy Markdown
Owner

Summary

  • Add 8 new E2E tests to settings.spec.ts covering previously untested settings sections:
    • Staging Directory: path field save, use staging checkbox toggle
    • Archive Extraction: extract-in-downloads-directory checkbox toggle
    • Integrity Check: verify checkbox + algorithm select presence, algorithm select save/restore
    • Connections: max parallel downloads field save
    • Notifications: Discord/Telegram webhook field presence
    • Logging: log level dropdown persistence after page reload

Test plan

  • CI passes (Playwright tests require running container)
  • All tests restore original config values in finally blocks
  • No flaky tests — uses expect.poll() for async backend verification

🤖 Generated with Claude Code

Add coverage for previously untested settings sections:
- Staging Directory: path field save, use staging checkbox toggle
- Archive Extraction: extract in downloads directory toggle
- Integrity Check: verify checkbox + algorithm select presence, algorithm save
- Connections: max parallel downloads field save
- Notifications: Discord/Telegram webhook field presence
- Logging: log level dropdown persistence after page reload

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Warning

Rate limit exceeded

@nitrobass24 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 38 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c2ec888a-96d4-4956-b661-fe2957244981

📥 Commits

Reviewing files that changed from the base of the PR and between cf856e6 and d454245.

📒 Files selected for processing (1)
  • src/e2e-playwright/tests/settings.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/e2e-settings-expansion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 46 minutes and 38 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitrobass24 nitrobass24 changed the title Expand E2E settings tests with 8 new tests PR 11: E2E — Settings Coverage Expansion May 1, 2026
nitrobass24 and others added 4 commits May 1, 2026 11:35
The hash algorithm select test's finally block used UI interaction
(selectOption) to restore the original value, but the page/browser
may already be torn down by that point. Switch to apiSetConfig which
makes a direct HTTP call and doesn't depend on the page being open.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Hash Algorithm select is disabled when xfer_verify is false
(the default). Enable it via API before testing, and restore the
original state in the finally block.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Set the xfer_verify config via API BEFORE navigating to the settings
page, so the page loads with the select already enabled. Use
waitForStream to ensure SSE config delivery before interacting.
Increase toBeEnabled timeout to 10s for CI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The algorithm select is disabled when its value is null/undefined
(option.component.html). Wait for the SSE config delivery to populate
the select value before asserting it's enabled.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nitrobass24 nitrobass24 merged commit 0cc3533 into develop May 2, 2026
17 of 18 checks passed
@nitrobass24 nitrobass24 deleted the test/e2e-settings-expansion branch May 2, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant