Skip to content

Track Playwright package-lock.json so CI cache step resolves#453

Merged
nitrobass24 merged 1 commit into
developfrom
fix/playwright-lockfile
May 2, 2026
Merged

Track Playwright package-lock.json so CI cache step resolves#453
nitrobass24 merged 1 commit into
developfrom
fix/playwright-lockfile

Conversation

@nitrobass24
Copy link
Copy Markdown
Owner

Summary

  • Add !src/e2e-playwright/package-lock.json to root .gitignore (the existing package-lock.json rule was filtering it out, alongside angular and website allow-list entries)
  • Commit the generated lockfile so actions/setup-node's cache-dependency-path resolves and npm ci has something to install from

Why

Playwright caching landed in #452, but the workflow references src/e2e-playwright/package-lock.json and that file was being silently filtered by .gitignore. CI on develop (and any new PR against it) fails at the Set up Node.js step with:

##[error]Some specified paths were not resolved, unable to cache dependencies.

npm ci on the next line would also have failed without a lockfile. Adding the allow-list entry plus the lockfile unblocks the cache step and the subsequent install.

Test plan

  • CI on this PR passes the Set up Node.js, Install Playwright dependencies, Cache Playwright browsers, Install Playwright browsers, and Run E2E tests steps
  • On a re-run, the Playwright browser cache step reports a hit (Cache hit for ...) and Install Playwright browsers is skipped

🤖 Generated with Claude Code

The Playwright caching added in #452 references src/e2e-playwright/package-lock.json, but the root .gitignore was filtering all package-lock.json files except the angular and website ones. With no lockfile in the repo, actions/setup-node failed at "Some specified paths were not resolved, unable to cache dependencies" and the npm ci step would have failed too.

Add an allow-list entry for src/e2e-playwright and check in the generated lockfile.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@nitrobass24 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 2 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 327e0dc4-e17c-4830-ba7b-bb75a57c51ae

📥 Commits

Reviewing files that changed from the base of the PR and between c3f8a91 and 7c8d360.

⛔ Files ignored due to path filters (1)
  • src/e2e-playwright/package-lock.json is excluded by !**/package-lock.json, !**/package-lock.json
📒 Files selected for processing (1)
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/playwright-lockfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 18 minutes and 2 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitrobass24 nitrobass24 merged commit 12047c5 into develop May 2, 2026
18 checks passed
@nitrobass24 nitrobass24 deleted the fix/playwright-lockfile branch May 2, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant