fix: remove horizontal scroll on mobile#87
Conversation
Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/c445c01a-a06a-4a77-95d2-65c06ac36a3d Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughI Pity the Foo' Who Don't Read This PR, Sucka!WalkthroughListen up, fool! This PR be droppin' some CSS fixes on ya to squash mobile horizontal scrolling issues and make that grid layout more responsive. We be tweakin' the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
I pity the fool who doesn't test these responsive changes on mobile devices, sucka! 💪 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
👁️ PR Preview
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 242 242
Branches 109 109
=========================================
Hits 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Mobile browsers (particularly iOS Safari) can expose a horizontal scroll despite
overflow-x: hiddenon bothhtmlandbody, due to howposition: fixedelements near the right viewport edge contribute to scroll-width calculations, and grid columns with hard pixel minimums overflowing narrow containers.Changes
styles/base.css— addoverflow: hiddento.github-cornerPrevents the
position: fixed; right: 0anchor element from being included in iOS Safari's viewport scroll-width calculation.styles/content-pages.css— tighten.news-gridcolumn minimumminmax(300px, 1fr)→minmax(min(300px, 100%), 1fr)On 320 px viewports the content area is ~280 px; a hard 300 px minimum overflows the container by 20 px. The
min()clamp ensures the floor never exceeds the available width.Summary by CodeRabbit