Skip to content

Quality/precommit guardrails#5

Merged
billsonnn merged 6 commits intonitrodevco:mainfrom
Diddyy:quality/precommit-guardrails
Feb 8, 2026
Merged

Quality/precommit guardrails#5
billsonnn merged 6 commits intonitrodevco:mainfrom
Diddyy:quality/precommit-guardrails

Conversation

@Diddyy
Copy link
Copy Markdown
Contributor

@Diddyy Diddyy commented Feb 7, 2026

This pull request introduces a comprehensive quality and workflow overhaul for the Turbo Sample Plugin repository. It establishes a two-phase quality model (fast check and full gate), adds CI integration, normalizes line endings, and provides detailed contributor documentation and protocol placement rules. The changes also improve package version pinning and enforce critical serialization diagnostics for safety.

Quality and Workflow Automation

  • Added .githooks/pre-commit and .githooks/pre-push scripts to enforce staged file formatting and quality checks for all commits and pushes. [1] [2]
  • Introduced .github/workflows/quality.yml for multi-platform CI quality gate, running full checks on push and pull request.
  • Defined TurboSamplePluginFastCheck and TurboSamplePluginQualityGate MSBuild targets for fast and full quality validation in Directory.Build.targets.

Contributor Documentation and Protocol Placement

  • Added and updated documentation files: README.md, CONTRIBUTING.md, AGENTS.md, CLAUDE.md, CODEX.md, and revision protocol placement guides, clarifying build scope, workflow, protocol mapping rules, and cross-repo boundaries. [1] [2] [3] [4] [5] [6] [7]

Tooling and Package Management

  • Added global.json to pin .NET SDK version and updated Directory.Packages.props to support fallback local package versions if central versions are unavailable, ensuring reproducible builds. [1] [2] [3]
  • Removed csharpier from .config/dotnet-tools.json, transitioning formatting enforcement to CI and hooks.

Line Ending and Formatting Enforcement

  • Updated .gitattributes to enforce LF line endings for source/tooling files and CRLF for solution/batch files, preventing cross-platform formatting issues.

Build Diagnostics and Safety

  • Enforced critical Orleans serialization warnings as errors to improve contributor safety in Directory.Build.props.

Copilot AI review requested due to automatic review settings February 7, 2026 13:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces repo-wide quality/workflow guardrails for the Turbo Sample Plugin, including local git hooks, CI quality gates, SDK pinning, and expanded contributor/protocol documentation.

Changes:

  • Added pre-commit/pre-push hooks plus MSBuild “fast check” and “quality gate” targets.
  • Added multi-OS GitHub Actions workflow to run the quality gate.
  • Added bootstrap + integrated dev scripts and expanded docs (contributing, agent notes, revision protocol rules), plus SDK/package/line-ending normalization.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
scripts/dev-integrated.sh Adds a shell helper for integrated plugin + core build/run.
scripts/dev-integrated.ps1 Adds a PowerShell helper for integrated plugin + core build/run.
scripts/bootstrap.sh Adds bootstrap script for hooks + env file + smoke build.
scripts/bootstrap.ps1 Adds bootstrap script for hooks + env file + smoke build (PowerShell).
global.json Pins .NET SDK version for reproducible builds.
TurboSamplePlugin/Revision/Revision20260112/README.md Adds revision-specific mapping checklist.
TurboSamplePlugin/Revision/README.md Documents protocol revision contract and cross-repo boundaries.
README.md Documents quickstart, workflow, and two-phase quality model.
Directory.Packages.props Adds central package import fallback logic and local version fallbacks.
Directory.Build.targets Introduces TurboSamplePluginFastCheck and TurboSamplePluginQualityGate targets.
Directory.Build.props Treats specific Orleans serialization warnings as errors.
CONTRIBUTING.md Adds contributor workflow/quality documentation.
CODEX.md Adds AI/tool adapter guidance and validation commands.
CLAUDE.md Adds AI/tool adapter guidance and validation commands.
AGENTS.md Adds plugin-specific placement rules + revision checklist.
.github/workflows/quality.yml Adds CI workflow to run the quality gate across OSes.
.githooks/pre-push Runs quality gate before push.
.githooks/pre-commit Runs staged-file formatting check + fast check before commit.
.gitattributes Normalizes line endings across file types.
.config/dotnet-tools.json Removes pinned tools (currently leaves no tools to restore).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .config/dotnet-tools.json
Comment thread .github/workflows/quality.yml
Comment thread CONTRIBUTING.md
Comment thread .github/workflows/quality.yml
Comment thread .githooks/pre-push
@Diddyy
Copy link
Copy Markdown
Contributor Author

Diddyy commented Feb 7, 2026

Tested Locally in multiple clean environments. Co-Pilots suggestions are all unneeded at this time.

@billsonnn billsonnn merged commit e69e174 into nitrodevco:main Feb 8, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants