Merged
Conversation
- standardize plugin quality checks and hooks around dotnet build/format\n- add contributor/bootstrap docs and pinned SDK tooling metadata\n- document revision packet mapping checklist for Headers/Parsers/Serializers
There was a problem hiding this comment.
Pull request overview
This PR introduces repo-wide quality/workflow guardrails for the Turbo Sample Plugin, including local git hooks, CI quality gates, SDK pinning, and expanded contributor/protocol documentation.
Changes:
- Added pre-commit/pre-push hooks plus MSBuild “fast check” and “quality gate” targets.
- Added multi-OS GitHub Actions workflow to run the quality gate.
- Added bootstrap + integrated dev scripts and expanded docs (contributing, agent notes, revision protocol rules), plus SDK/package/line-ending normalization.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/dev-integrated.sh |
Adds a shell helper for integrated plugin + core build/run. |
scripts/dev-integrated.ps1 |
Adds a PowerShell helper for integrated plugin + core build/run. |
scripts/bootstrap.sh |
Adds bootstrap script for hooks + env file + smoke build. |
scripts/bootstrap.ps1 |
Adds bootstrap script for hooks + env file + smoke build (PowerShell). |
global.json |
Pins .NET SDK version for reproducible builds. |
TurboSamplePlugin/Revision/Revision20260112/README.md |
Adds revision-specific mapping checklist. |
TurboSamplePlugin/Revision/README.md |
Documents protocol revision contract and cross-repo boundaries. |
README.md |
Documents quickstart, workflow, and two-phase quality model. |
Directory.Packages.props |
Adds central package import fallback logic and local version fallbacks. |
Directory.Build.targets |
Introduces TurboSamplePluginFastCheck and TurboSamplePluginQualityGate targets. |
Directory.Build.props |
Treats specific Orleans serialization warnings as errors. |
CONTRIBUTING.md |
Adds contributor workflow/quality documentation. |
CODEX.md |
Adds AI/tool adapter guidance and validation commands. |
CLAUDE.md |
Adds AI/tool adapter guidance and validation commands. |
AGENTS.md |
Adds plugin-specific placement rules + revision checklist. |
.github/workflows/quality.yml |
Adds CI workflow to run the quality gate across OSes. |
.githooks/pre-push |
Runs quality gate before push. |
.githooks/pre-commit |
Runs staged-file formatting check + fast check before commit. |
.gitattributes |
Normalizes line endings across file types. |
.config/dotnet-tools.json |
Removes pinned tools (currently leaves no tools to restore). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Tested Locally in multiple clean environments. Co-Pilots suggestions are all unneeded at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive quality and workflow overhaul for the Turbo Sample Plugin repository. It establishes a two-phase quality model (fast check and full gate), adds CI integration, normalizes line endings, and provides detailed contributor documentation and protocol placement rules. The changes also improve package version pinning and enforce critical serialization diagnostics for safety.
Quality and Workflow Automation
.githooks/pre-commitand.githooks/pre-pushscripts to enforce staged file formatting and quality checks for all commits and pushes. [1] [2].github/workflows/quality.ymlfor multi-platform CI quality gate, running full checks on push and pull request.TurboSamplePluginFastCheckandTurboSamplePluginQualityGateMSBuild targets for fast and full quality validation inDirectory.Build.targets.Contributor Documentation and Protocol Placement
README.md,CONTRIBUTING.md,AGENTS.md,CLAUDE.md,CODEX.md, and revision protocol placement guides, clarifying build scope, workflow, protocol mapping rules, and cross-repo boundaries. [1] [2] [3] [4] [5] [6] [7]Tooling and Package Management
global.jsonto pin .NET SDK version and updatedDirectory.Packages.propsto support fallback local package versions if central versions are unavailable, ensuring reproducible builds. [1] [2] [3]csharpierfrom.config/dotnet-tools.json, transitioning formatting enforcement to CI and hooks.Line Ending and Formatting Enforcement
.gitattributesto enforce LF line endings for source/tooling files and CRLF for solution/batch files, preventing cross-platform formatting issues.Build Diagnostics and Safety
Directory.Build.props.