Skip to content

Conversation

@NBruhno
Copy link
Contributor

@NBruhno NBruhno commented Nov 13, 2025

πŸ”— Linked issue

#3784

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It might be a hard fetch to call it a "new feature", but this change makes it so the ServerRequest type from srvx is re-exported from nitro/types. This makes it easier to type functions, e.g. helper functions utilizing the useRequest() async context util.

This is the first time I'm contribution to anothers repo like this so let me know if I missed some steps or if there is something else needed.

I also have no issue if this change is unwanted, it is not a big deal to have to import the type from srvx instead.

Resolves #3784

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@NBruhno NBruhno requested a review from pi0 as a code owner November 13, 2025 17:03
@vercel
Copy link

vercel bot commented Nov 13, 2025

@NBruhno is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@pi0 pi0 changed the title feat: Re-export ServerRequest type from srvx feat: export ServerRequest from nitro/types Nov 16, 2025
@pi0 pi0 merged commit 6579994 into nitrojs:main Nov 16, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export the ServerRequest type from srvx

2 participants