Skip to content

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented Nov 14, 2025

πŸ”— Linked issue

resolves #2311

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

seems like a relatively straightforward change

I'll open a similar one for netlify as well

having looked at both implementations, I'm not sure we need a manifest before merging this, but please do feel free to tell me if I've taken a wrong turn here.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nitro.build Ready Ready Preview Comment Nov 16, 2025 2:03pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/nitrojs/nitro/nitropack@3787

commit: fd9ea71

@pi0
Copy link
Member

pi0 commented Nov 15, 2025

having looked at both implementations, I'm not sure we need a #2312 before merging this, but please do feel free to tell me if I've taken a wrong turn here.

Not (generated) manifest, but we need a configuration namespace manifest: { deploymentId } that stores VERCEL_DEPLOYMENT_ID.

Also can you please reopen on main branch? We can backport it later steps.

@danielroe danielroe mentioned this pull request Nov 16, 2025
3 tasks
@pi0 pi0 merged commit 2587261 into main Nov 16, 2025
10 checks passed
@pi0 pi0 deleted the feat/vercel-skew branch November 16, 2025 14:18
@gerynugrh
Copy link

Hi @danielroe this is really interesting, is there a way for me to use this right now?

@pi0
Copy link
Member

pi0 commented Dec 16, 2025

https://nitro.build/guide/nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skew protection on Vercel

4 participants