Skip to content

Conversation

@huseeiin
Copy link
Contributor

add netlify edge ip support

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@huseeiin huseeiin requested a review from pi0 as a code owner January 14, 2026 13:20
@vercel
Copy link

vercel bot commented Jan 14, 2026

@huseeiin is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

πŸ“ Walkthrough

Walkthrough

This change adds a single line to the Netlify Edge runtime configuration that propagates the client IP address from the context into the ServerRequest object, enriching the request with the caller's IP before further processing.

Changes

Cohort / File(s) Summary
Netlify Edge Runtime Configuration
src/presets/netlify/runtime/netlify-edge.ts
Added property assignment to propagate client IP address from context into the request object (req.ip = context.ip) prior to runtime initialization

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

πŸš₯ Pre-merge checks | βœ… 3
βœ… Passed checks (3 passed)
Check name Status Explanation
Description check βœ… Passed The description 'add netlify edge ip support' is related to the changeset, though minimal detail is provided beyond the topic.
Docstring Coverage βœ… Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check βœ… Passed The PR title 'feat(netlify-edge): support req.ip' follows conventional commits format with appropriate scope and description of the feature addition.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • πŸ“ Generate docstrings
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 14, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nitrojs/nitro@3946

commit: f77c56d

@pi0 pi0 changed the title add netlify edge ip feat(netlify-edge): support req.ip Jan 20, 2026
@pi0 pi0 merged commit 795e774 into nitrojs:main Jan 20, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants