Skip to content

chore: update pnpm config#4208

Merged
pi0 merged 5 commits intomainfrom
chore/update-pnpm-config
Apr 22, 2026
Merged

chore: update pnpm config#4208
pi0 merged 5 commits intomainfrom
chore/update-pnpm-config

Conversation

@btea
Copy link
Copy Markdown
Contributor

@btea btea commented Apr 16, 2026

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

dedupePeers refers to https://github.com/pnpm/pnpm/releases/tag/v10.33.0

allowBuilds refers to https://pnpm.io/settings#allowbuilds

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@btea btea requested a review from pi0 as a code owner April 16, 2026 13:05
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nitro.build Ready Ready Preview, Comment Apr 22, 2026 1:07pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c5d34e0-ec46-4915-962b-7f651bde194c

📥 Commits

Reviewing files that changed from the base of the PR and between a9ad58f and 5f79faf.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Updated pnpm-workspace.yaml: moved core workspace flags to top-level (shellEmulator, dedupePeers, ignoreWorkspaceRootCheck), replaced build filters (ignoredBuiltDependencies, onlyBuiltDependencies) with allowBuilds: {} and stricter build controls, switched peer dependency handling to allowedVersions for vite and typescript, and reduced trustPolicyExclude to semver@6.3.1. (48 words)

Changes

Cohort / File(s) Summary
pnpm workspace config
pnpm-workspace.yaml
Relocated top-level settings: added shellEmulator: true, dedupePeers: true, ignoreWorkspaceRootCheck: true, kept trustPolicy: no-downgrade. Removed ignoredBuiltDependencies / onlyBuiltDependencies; added blockExoticSubdeps: true, strictDepBuilds: true, allowBuilds: {}. Switched peerDependencyRules from ignoreMissing entries to allowedVersions (vite: "8", typescript: "6"). Trimmed trustPolicyExclude to only semver@6.3.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • chore: update pnpm config #4208 — Mirrors same pnpm-workspace.yaml changes: top-level flags relocation, build filter replacement with allowBuilds, peerDependencyRulesallowedVersions, and trustPolicyExclude simplification.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: update pnpm config' follows conventional commits format with a descriptive message that accurately reflects the configuration update in the changeset.
Description check ✅ Passed The description relates to the changeset by referencing specific pnpm settings changes (dedupePeers and allowBuilds) that align with the configuration updates in pnpm-workspace.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-pnpm-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 16, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4208

commit: a9ad58f

Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx ❤️

@pi0 pi0 merged commit 96fe6b2 into main Apr 22, 2026
1 of 9 checks passed
@pi0 pi0 deleted the chore/update-pnpm-config branch April 22, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants