presets(cloudflare): add missing types for cloudflare.wrangler.observability.traces#4220
Conversation
|
@gxres042 is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughExtended the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/presets/cloudflare/wrangler/environment.ts`:
- Around line 1138-1142: The traces config type in environment.ts (the traces?:
{ ... } declaration) is missing two documented fields; update that type by
adding destinations?: string[] to accept an array of OpenTelemetry export
destination names and persist?: boolean (optional, default true per Cloudflare
docs) so TypeScript accepts valid wrangler configs; keep both fields optional
and include brief jsdoc comments if present elsewhere for consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 31e05756-c1ac-4a70-9b57-502979f54e6b
📒 Files selected for processing (1)
src/presets/cloudflare/wrangler/environment.ts
commit: |
cloudflare.wrangler.observability.traces
cloudflare.wrangler.observability.tracescloudflare.wrangler.observability.traces
🔗 Linked issue
#4215
❓ Type of change
📚 Description
Resolves #4215
📝 Checklist