Skip to content

feat: add rmi touchpad support #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: add rmi touchpad support #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pkg/hwinfo/input.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ import (
"fmt"
"log/slog"

"github.com/numtide/nixos-facter/pkg/udev"

"github.com/numtide/nixos-facter/pkg/linux/input"
"github.com/numtide/nixos-facter/pkg/udev"
)

// captureTouchpads scans the input devices and identifies touchpads, returning a slice of HardwareDevice structs or an
Expand All @@ -22,7 +21,6 @@ func captureTouchpads(deviceIdx uint) ([]HardwareDevice, error) {
var result []HardwareDevice //nolint:prealloc

for _, inputDevice := range inputDevices {

path := "/sys" + inputDevice.Sysfs

udevData, err := udev.Read(path)
Expand Down Expand Up @@ -81,6 +79,17 @@ func captureTouchpads(deviceIdx uint) ([]HardwareDevice, error) {
Value: uint16(SubClassMousePs2),
}

case input.BusRmi:
// RMI is a protocol which runs over other physical buses, typically i2c, but it can also be over others
// such as USB or SPI.
// I'm not sure how to map this into hwinfo's bus classification, so for now we will use other for both the
// bus and mouse subclass.
hd.BusType = NewBusID(BusOther)
hd.SubClass = &ID{
Name: SubClassMouseOther.String(),
Value: uint16(SubClassMouseOther),
}

case input.BusPci,
input.BusIsapnp,
input.BusHil,
Expand All @@ -97,7 +106,6 @@ func captureTouchpads(deviceIdx uint) ([]HardwareDevice, error) {
input.BusGsc,
input.BusAtari,
input.BusSpi,
input.BusRmi,
input.BusCec,
input.BusIntelIshtp,
input.BusAmdSfh:
Expand Down