modules/lsp/servers/vls: do not add filetype extension if not enabled #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2024
traxys
approved these changes
Jul 21, 2024
Member
|
(You may want to rebase on main for the commit attribution) |
| }; | ||
| extraConfig = cfg: { filetype.extension = mkIf cfg.autoSetFiletype { v = "vlang"; }; }; | ||
| extraConfig = cfg: { | ||
| filetype.extension = mkIf (cfg.enable && cfg.autoSetFiletype) { v = "vlang"; }; |
Member
There was a problem hiding this comment.
I wonder if the issue here is actually _mk-lsp.nix not having mkIf cfg.enable like the other mkPlugins do in our helper lib?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option
plugins.lsp.servers.vls.autoSetFiletypeadds filetype extension by default, even whenplugins.lsp.servers.vls.enable = false. I think this is not intended behavior.My main goal is to make
filessubmodules to produce empty configs by default. When I doI expect
ftplugin/nix.luato have only this option, and nothing else.