modules/filetype: ensure that modules does not provide empty settings #1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helpers.mkIfNonNull'checks only for value = null, but I noticed that when there is anywhere something likemkIf false config.filename = {}(like with vlang filetype currently in nixvim, see also #1907), value ofconfig.filetypeis not null, but has all attrs with null values. It can be debugged withnix repl:Notice that
condition = false, but the value is not null.This PR changes mkIf condition to account for that.
NOTE: Test
checks.x86_64-linux.tests.entries.modules-filetypeswill fail until #1907 is merged.