Support for no-change of parameters of setresuid and setresgid #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Jan 8, 2019
CHANGELOG.md
Outdated
| - Added `symlinkat` wrapper. | ||
| ([#997](https://github.com/nix-rust/nix/pull/997)) | ||
| - Support for no-change of parameters of `setresuid` and `setresgid` wrapper | ||
| ([#931](https://github.com/nix-rust/nix/issues/931)) |
Member
There was a problem hiding this comment.
Link to the pull request, not the issue.
Author
There was a problem hiding this comment.
Fixed... So used to linking to the issue.
edwinbdr
force-pushed
the
parameters-setresuid
branch
from
778b302 to
a2d718b
Compare
asomers
approved these changes
Jan 8, 2019
Member
|
I'm not sure why your test is segfaulting in QEMU. Can you look into it? |
Author
|
I can't figure it out as well atm. It seems to work fine on my virtualbox linux distro. It also seems to work fine with a variety of different machines. Perhaps you could help? |
Member
|
Are you using Linux? If so, why don't you try running the test locally using qemu. If it still segfaults, then try writing a C program that uses setresgid and see if that segfaults under qemu too. |
Author
|
I am trying, but running into a qemu issue with osx. Apparently, osx is not backward compatible, again. |
ritzk
added a commit
to ritzk/nix
that referenced
this pull request
Oct 4, 2020
ritzk
pushed a commit
to ritzk/nix
that referenced
this pull request
Oct 4, 2020
ritzk
pushed a commit
to ritzk/nix
that referenced
this pull request
Oct 4, 2020
…st#1009 - Fixes nix-rust#931 - test setresgid/setresuid with None
ritzk
pushed a commit
to ritzk/nix
that referenced
this pull request
Oct 11, 2020
…st#1009 - Fixes nix-rust#931 - test setresgid/setresuid with None
ritzk
pushed a commit
to ritzk/nix
that referenced
this pull request
Oct 11, 2020
…st#1009 - Fixes nix-rust#931 - test setresgid/setresuid with None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931