ci: stage nksdeploy phar from plugin release#51
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69947460d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (pluginId === 'nks.wdc.deploy') { | ||
| const pharAsset = (rel.assets ?? []).find(a => a.name === 'nksdeploy.phar') | ||
| if (pharAsset) { | ||
| await downloadToFile(pharAsset.browser_download_url, join(destDir, 'nksdeploy.phar')) |
There was a problem hiding this comment.
The new nksdeploy.phar fetch runs inside the same try block that controls all release staging, so any transient failure on this optional asset (e.g., 404/403/network) throws and skips sourceUsed assignment, after which the script reports “No plugin build output found” and can process.exit(1) in CI even if plugin ZIPs were already extracted. This turns a fallback artifact failure into a full bundle failure; the phar download should be handled non-fatally (or separately) so DLL staging success is preserved.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification