enhancement: improve named field handling in PatternNameGenerator#80
Merged
maeb merged 1 commit intonlnwa:masterfrom Mar 31, 2025
Merged
enhancement: improve named field handling in PatternNameGenerator#80maeb merged 1 commit intonlnwa:masterfrom
maeb merged 1 commit intonlnwa:masterfrom
Conversation
Improves field handling by: - Exporting 'params' field as 'Params' for external configuration - Ensuring predefined fields (ts, serial, hostOrIp, etc) take precedence over custom ones - Adding documentation to clarify parameter behavior - Adding tests for custom fields and precedence rules Fixes nlnwa#79
maeb
approved these changes
Mar 31, 2025
Member
maeb
left a comment
maeb
left a comment
There was a problem hiding this comment.
Looks good to me. Sorry for the late response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves field handling by:
ts,serial,hostOrIp, etc) take precedence over custom onesFixes #79