docs: clarify error_handler_t::ignore UTF-8 behavior#5181
Closed
leno23 wants to merge 1 commit into
Closed
Conversation
Document that ignore skips invalid sequences during dump rather than copying every byte unchanged (nlohmann#4552).
leno23
force-pushed
the
docs/dump-error-handler-ignore-4552
branch
from
30fb2f4 to
4f13fed
Compare
1 task
Owner
|
I do not like AI-generated documentation. The behavior right now is a bit buggy. It should be fixed or better exemplified. Linking issues is not helpful here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align documentation with actual
error_handler_t::ignorebehavior duringdump(): invalid UTF-8 sequences are skipped from the output, not copied byte-for-byte.Updates
dump.md,error_handler_t.md, andREADME.md. Points to #4552 and the proposedkeephandler in #4555.Motivation
Fixes confusion reported in #4552 without changing runtime semantics while #4555 is discussed.
Test plan
Made with Cursor