Fix issue #3326#3337
Open
Adv2924 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read the source code and, from my understanding, the current output appears to be intentional. The
ipv4value being shown seems to refer to the next header, i.e., the protocol of the packet encapsulated within the outer packet, which in this case is IPv6.Since the user has explicitly specified
-6in the command, it seems reasonable to assume that the outgoing packets are expected to be in IPv6 format rather than IPv4.That said, I understand how this could lead to confusion. To improve clarity, I have added a fix in the else statement at line 3127 in libnetutil/netutil.cc, which checks whether hdr.version is set to 6 and updates the logging accordingly.