-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hadoop Fingerprints #715
Conversation
This will need a bit of touch-up:
Please let me know if you have any questions or concerns. |
@nnposter Made the required changes |
The singe-quote escaping is still incorrect for two reasons:
Let's also try to tighten the Cloudera Manager pattern to make it more future-proof against false-positives. The relevant payload to be parsed is: <script type="text/javascript">
var clouderaManager = {
version: '5.7.0',
state: '0',
license: 'no uuid', So let's:
The end-result would be something like:
For the YARN patterns we might be grabbing too much of the versioning information.
If we stop at the version itself, not including the source of the version, then we could collect and combine all three pieces of information, namely the RM version, state, and Hadoop version, still producing a relatively compact one-liner:
I am not sure if we should care for the full version. Anybody believes otherwise? The implementation could look something like: {
match = 'ResourceManager state:.-<td>%s*([^%s<]*)'
.. '.-ResourceManager version:.-<td>%s*([^%s<]*)'
.. '.-Hadoop version:.-<td>%s*([^%s<]*)',
output = 'Hadoop YARN Resource Manager version \\2,'
.. ' state "\\1", Hadoop version \\3'
}, A similar extraction pattern could be used for Node Manager. I would also drop the following part entirely. It is redundant: {
match = '<h3>%s*NodeManager%s*</h3>',
output = 'Hadoop YARN Node Manager WebUI'
}, |
Thanks for the update! Updating PR shortly |
I did not intend to say that you should just replace "Resource" with "Node". The newly updated Node Manager pattern is no longer matching the literal strings observable in Thomas' scripts, such as "NodeManager" vs. "Node Manager" or the absence of the state. I have made those adjustments and I am committing the fingerprints shortly. |
Sorry to re-open that conversation but it could be a good idea to take the old hadoop modules and integrate the probes into the |
With reference to a comment on #620 . Intended for easy reviewing