Skip to content

Implement Breathing effect, permitting the user to chose it's own luminosity#41

Merged
nmaupu merged 6 commits intonmaupu:masterfrom
Samt43:breath_effect
Feb 12, 2026
Merged

Implement Breathing effect, permitting the user to chose it's own luminosity#41
nmaupu merged 6 commits intonmaupu:masterfrom
Samt43:breath_effect

Conversation

@Samt43
Copy link
Copy Markdown
Contributor

@Samt43 Samt43 commented Feb 10, 2026

Implement Breathing effect, permitting the user to chose it's own luminosity using mqtt interface or HA.
image

Copy link
Copy Markdown
Owner

@nmaupu nmaupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart :)
Nothing much to change, only coding style and typos.

It should be possible to set the brightness directly via a payload but I never figured out how 🤔 !

Comment thread src/main.cpp Outdated
Comment thread src/main.cpp Outdated
Comment thread src/commands/callbacks.cpp Outdated
Comment thread src/RF/device.cpp Outdated
Comment thread src/main.cpp Outdated
@Samt43
Copy link
Copy Markdown
Contributor Author

Samt43 commented Feb 10, 2026

Smart :) Nothing much to change, only coding style and typos.

It should be possible to set the brightness directly via a payload but I never figured out how 🤔 !

Maybe we could try a brute force buf[0] from 0 to 255 and setting some value in buf[4] and buf[5] ?
Have you tried this already ?

@Samt43
Copy link
Copy Markdown
Contributor Author

Samt43 commented Feb 10, 2026

Thanks a lot, that's a really nice project and it's working very well !

@nmaupu
Copy link
Copy Markdown
Owner

nmaupu commented Feb 10, 2026

Smart :) Nothing much to change, only coding style and typos.
It should be possible to set the brightness directly via a payload but I never figured out how 🤔 !

Maybe we could try a brute force buf[0] from 0 to 255 and setting some value in buf[4] and buf[5] ? Have you tried this already ?

I probably tried when I reversed the thing but I don't remember quite honestly.

@nmaupu
Copy link
Copy Markdown
Owner

nmaupu commented Feb 10, 2026

Formatting is still not ok.

Comment thread src/main.cpp Outdated
Comment thread src/main.cpp Outdated
Comment thread src/main.cpp Outdated
Comment thread src/main.cpp Outdated
@Samt43
Copy link
Copy Markdown
Contributor Author

Samt43 commented Feb 10, 2026

Sorry, my eyes are not used to this formatting !
Thanks again for this project !

@Samt43 Samt43 requested a review from nmaupu February 11, 2026 12:26
Comment thread src/main.cpp Outdated
@nmaupu nmaupu merged commit 3a1c768 into nmaupu:master Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants