fix: count reconnect attempts across failed handshakes - #89
Merged
Conversation
`conn_attempt` was set to 1 as soon as the upgrade request had been sent, so a server that accepted the TCP connection and then rejected the handshake, or dropped the session, reset the counter on every round. `handle_disconnect/3` always saw attempt 1, which pinned the default backoff at its 200ms minimum. Count in `handle_disconnect/2` instead, and reset only where the handshake actually completes.
vshev4enko
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conn_attemptwas set to 1 as soon as the upgrade request had been sent, so any server that accepted TCP and then rejected the handshake — or dropped the session — reset the counter every round.handle_disconnect/3always saw attempt 1, so the default backoff stayed at its 200ms minimum instead of growing.Counting moves to
handle_disconnect/2, which covers every disconnect path; the reset happens only in theMint.WebSocket.new/4success branch, where the handshake has actually completed.