-
Notifications
You must be signed in to change notification settings - Fork 14
PnotG #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
PnotG #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In draft mode until ping mode tests are added |
Contributor
Author
|
Ready for merge! |
Contributor
Author
|
closes #171. When ping: True |
pbashyal-nmdp
pushed a commit
to pbashyal-nmdp/py-ard
that referenced
this pull request
Oct 3, 2022
* works but not for G mode * ping mode * updated test to fix its behavior * remove lambdas, add and remove comments * fixed test expected results to new correct answer * ping tests * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement "ping" mode. (default ping =True)
When ping=True alleles in P-groups are included in addition to the alleles in G-groups in the corresponding lg/lgx groups.
This is primarily to address situations like
C*06:17reducing in lgx mode toC*06:02since it is in the P groupC*06:02Pbut not the G groupC*06:02:01G.Also the P-group and G-group names are now derived from the first allele.
This affects the following G-groups in the current lists:
These groups are now named for their first alleles (as they should be):
C*02:02:37GandDRB3*02:171:01G.This also has the effect of creating a P-group named
DRB3*02:171Pand adding the appropriate alleles toC*02:02P.This, in turn, has the effect of removing the
C*02:02/C*02:10from the "dup_lgx" table which means lgx redux onC*02:02returnsC*02:02now (notC*02:02/C*02:10).Likewise, lgx redux on
C*02:10returnsC*02:02now (notC*02:02/C*02:10).Which means py-ard will correctly reduce these alleles without the need for a post-pyard-fix.