Skip to content

Conversation

@mmaiers-nmdp
Copy link
Contributor

Implement "ping" mode. (default ping =True)

When ping=True alleles in P-groups are included in addition to the alleles in G-groups in the corresponding lg/lgx groups.

This is primarily to address situations like C*06:17 reducing in lgx mode to C*06:02 since it is in the P group C*06:02P but not the G group C*06:02:01G.

Also the P-group and G-group names are now derived from the first allele.
This affects the following G-groups in the current lists:

C*;02:02:37/02:10:01:01/02:10:01:02/02:10:01:03/02:10:01:04/02:10:01:05/02:10:01:06/02:10:01:07/02:10:01:08/02:10:01:09/02:10:01:10/02:10:01:11/02:10:01:12/02:10:01:13/02:10:01:14/02:10:01:15/02:10:01:16/02:10:01:17/02:10:01:18/02:10:01:19/02:10:03/02:10:04/02:10:05/02:10:07/02:10:08/02:168/02:169N/02:174/02:176/02:211Q;02:10:01G
DRB3*;02:171/02:173:01/02:173:02;03:22:01G

These groups are now named for their first alleles (as they should be): C*02:02:37G and DRB3*02:171:01G.

This also has the effect of creating a P-group named DRB3*02:171P and adding the appropriate alleles to C*02:02P.

This, in turn, has the effect of removing the C*02:02/C*02:10 from the "dup_lgx" table which means lgx redux on C*02:02 returns C*02:02 now (not C*02:02/C*02:10).

Likewise, lgx redux on C*02:10 returns C*02:02 now (not C*02:02/C*02:10).

Which means py-ard will correctly reduce these alleles without the need for a post-pyard-fix.

@mmaiers-nmdp mmaiers-nmdp marked this pull request as draft September 27, 2022 14:03
@mmaiers-nmdp
Copy link
Contributor Author

In draft mode until ping mode tests are added

@pbashyal-nmdp pbashyal-nmdp changed the title Pnotg Pnotg [WIP] Sep 27, 2022
@mmaiers-nmdp mmaiers-nmdp marked this pull request as ready for review September 28, 2022 14:59
@mmaiers-nmdp mmaiers-nmdp changed the title Pnotg [WIP] Pnotg Sep 29, 2022
@mmaiers-nmdp mmaiers-nmdp changed the title Pnotg PnotG Sep 29, 2022
@mmaiers-nmdp
Copy link
Contributor Author

Ready for merge!

@pbashyal-nmdp pbashyal-nmdp merged commit 0952a16 into nmdp-bioinformatics:master Sep 29, 2022
@mmaiers-nmdp
Copy link
Contributor Author

closes #171. When ping: True DQB1*02:02 reduces (lgx) to DQB1*02:01

pbashyal-nmdp pushed a commit to pbashyal-nmdp/py-ard that referenced this pull request Oct 3, 2022
* works but not for G mode

* ping mode

* updated test to fix its behavior

* remove lambdas, add and remove comments

* fixed test expected results to new correct answer

* ping tests

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants