Skip to content

Updated fix for the isvalid allele #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

Updated fix for the isvalid allele #28

merged 1 commit into from
Jan 24, 2020

Conversation

@jbrelsf2-nmdp
Copy link
Contributor

@jbrelsf2-nmdp jbrelsf2-nmdp commented Jan 24, 2020

The lambda check was invalidating value for self.valid.

Now returns true for allele if is mac.

@jbrelsf2-nmdp jbrelsf2-nmdp changed the title Updated fix for the isvalid gl into pyard.py Updated fix for the isvalid allele Jan 24, 2020
pbashyal-nmdp
pbashyal-nmdp approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@pbashyal-nmdp pbashyal-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pbashyal-nmdp pbashyal-nmdp merged commit 699fe6d into nmdp-bioinformatics:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbashyal-nmdp pbashyal-nmdp pbashyal-nmdp approved these changes

@mmaiers-nmdp mmaiers-nmdp Awaiting requested review from mmaiers-nmdp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrelsf2-nmdp @pbashyal-nmdp