Skip to content

Broad XX support, performance upgrades #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 21, 2020
Merged

Broad XX support, performance upgrades #33

merged 9 commits into from
Mar 21, 2020

Conversation

@mmaiers-nmdp
Copy link
Contributor

@mmaiers-nmdp mmaiers-nmdp commented Mar 20, 2020

  • added support for broad XX codes
  • converted list-based validation to dictionary based for performance
  • added caching for performance
  • precompiled regexes for performance
  • replaced implementation of smart sort with higher performing version (smart_sort.py)
  • added validation to catch things like C*13:XX

pbashyal-nmdp
pbashyal-nmdp approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@pbashyal-nmdp pbashyal-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbashyal-nmdp pbashyal-nmdp merged commit 61b11b5 into nmdp-bioinformatics:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbashyal-nmdp pbashyal-nmdp pbashyal-nmdp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmaiers-nmdp @pbashyal-nmdp