Skip to content

"lgx" and "lg" should only return 2-fields #40 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

"lgx" and "lg" should only return 2-fields #40 #46

merged 1 commit into from
Sep 8, 2020

Conversation

@pbashyal-nmdp
Copy link
Contributor

@pbashyal-nmdp pbashyal-nmdp commented Sep 4, 2020

ars type of lgx and lg should return 2-fields when not in G group

Fixes #40

@pbashyal-nmdp
Copy link
Contributor Author

pbashyal-nmdp commented Sep 4, 2020

With the changes:

>>> ard.redux_gl('DRB1*14:05:01', "lgx")
'DRB1*14:05'
>>> ard.redux_gl('DRB1*14:05:01', "lg")
'DRB1*14:05g'
>>> ard.redux_gl('DRB1*14:06:01', "lgx")
'DRB1*14:06'
>>> ard.redux_gl('DRB1*14:06:01', "lg")
'DRB1*14:06g'

@pbashyal-nmdp pbashyal-nmdp mentioned this pull request Sep 4, 2020
Merged
@rsajulga-nmdp rsajulga-nmdp mentioned this pull request Sep 8, 2020
Merged
5 tasks
@pbashyal-nmdp pbashyal-nmdp mentioned this pull request Sep 8, 2020
Merged
mmaiers-nmdp
mmaiers-nmdp approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@mmaiers-nmdp mmaiers-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmaiers-nmdp mmaiers-nmdp merged commit 73e372f into nmdp-bioinformatics:master Sep 8, 2020
@pbashyal-nmdp pbashyal-nmdp deleted the issue40_fix_lgx_lg branch October 27, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmaiers-nmdp mmaiers-nmdp mmaiers-nmdp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"lgx" and "lg" should only return 2-fields

2 participants

@pbashyal-nmdp @mmaiers-nmdp