Remove Unbounded Cache #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pbashyal-nmdp
commented
Oct 1, 2020
pbashyal-nmdp
commented
- The LRU cache was unbounded and is problematic when used in long running services. Set it to 1000.
- Use raw strings for regex characters
- General cleanup
- The LRU cache was unbounded and is problematic when used in long running services. Set it to 1000. - Use raw strings for regex characters - General cleanup
mmaiers-nmdp
approved these changes
Oct 1, 2020
Contributor
mmaiers-nmdp
left a comment
mmaiers-nmdp
left a comment
There was a problem hiding this comment.
Yes. Looks good to me.
Contributor
|
Have you done any timings on the performance with the cache limit? i can't imagine its a major hit. |
Contributor
Author
|
It'll help with performance but letting it be unbounded in terms of the cache size will balloon memory usage in long running services that include pyard as a dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.