Predict v3 from v2 #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ristic to convert to V3.
…into predict_v3_from_v2
mmaiers-nmdp
approved these changes
Feb 3, 2021
Contributor
mmaiers-nmdp
left a comment
mmaiers-nmdp
left a comment
There was a problem hiding this comment.
LGTM. Has this been tested against something like Nomenclature2010.pm?
Contributor
Author
|
No, I haven't. This is based on MG's Java code. |
Contributor
That can be an exercise for the reader. |
Contributor
Author
|
I looked through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_XXa public method on the ARD objectpyard-importfor importing into Latest