Invalid Agepro Model (Parametric Curve-Striped Marlin) questions

[efletcherPIFSC]

@michellesculley reported issues handling Striped Marlin Projections for 2000-2003 with AGEPRO GUI.

@JonBrodziak helping Michelle with the projections using the calculation engine workaround and contacted me raising this issue.
Testing the Agepro Input File for the 2000-2003 model into development version of AGEPRO-GUI returned a prompt:

Error loading AGEPRO input file:
Number of parametric curve parameters must be 3.
Number of parameters found: 1

---

12/13/2024 Update:

@JonBrodziak has detailed the origin of the issue in his email response :

The error originates in the input file for the projections - see line 94
in Phase_Q_2000-2003BL.inp - attached.

[RECRUIT]
1000  1  100
14  14  5
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
5
77.993719556902  149.840707425404  105.792183843178  114.541276227773  228.661166974672
20
167.224385270442  303.954813260105  183.011073213329  325.739373889996  258.262733626572  83.5137166804517  263.988843213593  96.2178782252057  179.580445765779  168.83816952147  69.8938814322408  239.336265823479  174.536797446695  68.3419309202539  278.636568950929  77.993719556902  149.840707425404  105.792183843178  114.541276227773  228.661166974672
268.776619643141748.1325373134330.36       

There are 3 Beverton-Holt recruitment parameters needed on line 94
and these parameters have been written out as a single string with no
spaces after the input processing in the AGEPRO GUI.

A corrected input file has the 3 parameters listed as numeric values
with a space limiter - see line 94 in Phase_Q_2000-2003BL-corrected-M5.inp.

[RECRUIT]
1000  1  100
14  14  5
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
0.12  0.84  0.04
5
77.993719556902  149.840707425404  105.792183843178  114.541276227773  228.661166974672
20
167.224385270442  303.954813260105  183.011073213329  325.739373889996  258.262733626572  83.5137166804517  263.988843213593  96.2178782252057  179.580445765779  168.83816952147  69.8938814322408  239.336265823479  174.536797446695  68.3419309202539  278.636568950929  77.993719556902  149.840707425404  105.792183843178  114.541276227773  228.661166974672
268.776619643141 748.132537313433 0.36        

When the GUI sets up the inputs for running the AGEPRO calculation engine
and overwrites the original input file, the GUI appears to have changed the
input data for the Beverton-Holt recruitment model 5. This may be occurring
for other parametric recruitment models as well.

Step to Reproduce

This issue is reproduceable with AGEPRO's example model 1

• Load AGEPRO-GUI
• File -> "Open Existing AGEPRO Input Data File" -> Select Example1.INP (and double check GUI points to bootstrap file Example1.BSN)
• Select Recruitment
• In the Recruitment tab, and replace Recruitment Model for Selection 1 by selecting Model 5: Beverton-Holt Curve w/ Lognormal Error in the dropdown box.
• In the Recruit Model tab, enter values for Alpha, Beta, and Variance (for this example: 268.776619643141, 748.132537313433, and 0.36)
• File -> "Save AGEPRO Input Data As .." and save to different filename (In this example Example1-model5.INP)
• Loading the new file will lead to error ("Number of parametric curve parameters must be 3.
  Number of parameters found: 1")
  • Checking original (Example1.INP) and altered(Example1-model5.inp) lead to the same situation @JonBrodziak described

Reproducing the same example model 1, but with smaller, less-precise values Alpha and Beta (268.7766 & 748.1325) retained its blank string delimiter.

Resolution

Parametric Curve numeric values w/ large precision, and a lack of blank string delimiter caused erroneous input files. Adding blank string delimiters to Parametric Curve values in its WriteRecruitmentDataModelData() resolves the issue.

For consistency, ensure blank string delimiters are used to output recruitment model values to AGEPRO input data file lines.

[efletcherPIFSC]

Confirmed that commit af3bd38 resolved issue.
Reproducing the steps with AGEPRO model 1 (Model 5: Alpha=268.776619643141, Beta=748.132537313433, Variance=0.36) did not result in a error, and input file maintained its precision.