NULL checks catches Stochastic Weight of Age when using another "Weight of Age" as data.

[efletcherPIFSC]

Issue

@JonBrodziak reported:

There is a problem with the AGEPRO Gui.
I tested each of the three projection examples in the release.

Of these, example 1 ran correctly while example 2 and example 3
produced run-time errors. The error messages were
"An error occurred when launching the AGEPRO Model.
System.NullReferenceExceptions: Stochastic Age of
[SSB_WEIGHT] is NULL ...".

Details

By design, the Weights of age and CV data tables are nullified (in GUI form and data) if that Stochastic Weight of Age "uses" another Weight of Age.

Based on initial tests on the RC1 codebase, the error @JonBrodziak reported is caused by running NULL error checks (implemented on nmfs-ost/AGEPRO-CoreLib@b12d763) before checking if the Stochastic Weight of Age is "using" another "Weight of Age" as data.

This also affects from file options (both Stochastic and Stochastic Weights of Age).

Solution

• Integrate the NULL checks to specific to User Specified Weights at Age to negate side effects.

[efletcherPIFSC]

Update 2/8/2019

Applied changes to NULL checks, and tested Example 2 and Example 3 Input file without problems.

However when I save a new user generated AGEPRO case, with a Stochastic Weight of Age using another Weight of Age. I this error:

Weights Stochastic Table File Does not exist 

Traced the issue to function ValidateStochasticParameter. Primary analysis: it is similar to original issue.

[efletcherPIFSC]

Update 2/11/2019

Traced the issue ValidateStochasticParameter (in ControlStochasticWeightAge.cs):
Reading AGEPRO input file sets the indexWeightOption. However, the indexWeightOption value doesn't change (unimplemented) when the user selects an Stochastic Weight of Ages radio button option.

[efletcherPIFSC]

Implemented indexWeightOption in commit 74c761a

Tested saving user generated AGEPRO new cases with:

• Model 5: Beverton-Holt; Bootstrap file
• SSBWeights: Use JAN1Weights
• CatchWeights use MidYearWeights

There was no NULL dialog errors. However, similar to issue #1, changes to SSBWeights and CatchWeights did not reflect to the written input file: The weightsOfAge values still retain their default values . Data Binding these changes to the input data object should resolve this issue.

[JonBrodziak]

Eric, Do you have a way to set the binding to define the stochastic weight at age table and fix the file saving bug ? This seems like an array definition issue and that it should be resolvable by initializing array pointers for stochastic weights at age. Jon Jon

…

On Fri, Feb 8, 2019 at 10:50 AM efletcherPIFSC ***@***.***> wrote: Issue @JonBrodziak <https://github.com/JonBrodziak> reported: There is a problem with the AGEPRO Gui. I tested each of the three projection examples in the release. Of these, example 1 ran correctly while example 2 and example 3 produced run-time errors. The error messages were "An error occurred when launching the AGEPRO Model. System.NullReferenceExceptions: Stochastic Age of [SSB_WEIGHT] is NULL ...". Details By design, the *Weights of age* and *CV* data tables are nullified (in GUI form and data) if that *Stochastic Weight of Age* "uses" another *Weight of Age*. Based on initial tests on the RC1 codebase, the error @JonBrodziak <https://github.com/JonBrodziak> reported is caused by running NULL error checks (implemented on ***@***.*** <nmfs-ost/AGEPRO-CoreLib@b12d763>) *before* checking if the Stochastic Weight of Age is "using" another "Weight of Age" as data. This also affects *from file* options (both Stochastic and Stochastic Weights of Age). Solution - Integrate the NULL checks to specific to *User Specified Weights at Age* to negate side effects. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKt0ZkfecHyTmwtxpnB-m_tA_6hjLbIQks5vLeMxgaJpZM4axjxa> .

-- Jon Brodziak, Ph.D. NOAA Inouye Regional Center Pacific Islands Fisheries Science Center 1845 Wasp Boulevard, Building 176, NMFS/PIFSC/FRMD Mail Room 2247 Honolulu, Hawaii 96818 USA Phone: 808-725-5617 Email: Jon.Brodziak@NOAA.GOV "Experience is the teacher of all things." ~ Julius Caesar The views expressed in this message are my own and do not necessarily reflect any position of NOAA.

[efletcherPIFSC]

@JonBrodziak

Commit 5c1ad2e takes care of the aforementioned data binding issues.