[Hotfix]: Make alttext work for cover image and when pandocbounded is not present#405
[Hotfix]: Make alttext work for cover image and when pandocbounded is not present#405Schiano-NOAA merged 5 commits intomainfrom
Conversation
Checklist
|
There was a problem hiding this comment.
Pull request overview
This hotfix addresses alt text handling for cover images and figures that don't have the pandocbounded wrapper in LaTeX documents. The changes unify the alt text format and simplify the logic for identifying which figure lines need alt text processing.
- Updated cover page alt text from
pdftooltipformat topandocboundedformat with inlinealt=attribute - Replaced loop-based filtering logic with direct artifact line removal to handle figures without
pandocbounded
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| R/utils_tex.R | Modified cover page alt text generation to use pandocbounded with inline alt= attribute instead of pdftooltip wrapper format |
| R/add_alttext.r | Simplified figure line filtering by directly removing artifact line instead of looping through all lines to check for pandocbounded |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Metrics Report
Code coverage of files in pull request scope (31.3%)
Reported by octocov |
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
Looks good! I'm not sure why only the mac R Cmd check is failing, but that happened to me last week and eventually it disappeared.
|
@sbreitbart-NOAA great! I'm going to push a check for the artifact then merge after checks |
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?