[Bug]: control.ss_new not writing 2D-AR1 parameter lines when sigma_amax < 0

[iantaylor-NOAA]

Describe the bug

The User Manual guidance on 2D-AR1 (semi-parametric) selectivity notes that "For simplicity, only a single sigma parameter line needs to be read if Sigma_Amax equals Amin, or if Sigma_Amax < 0."

However, the code to write the control.ss_new file doesn't include this option and just skips writing of the one parameter line:

ss3-source-code/SS_write_ssnew.tpl

Lines 2627 to 2634 in b8a5b59

	for (a = amin; a <= sigma_amax; a++)
	{
	dvector dtempvec(1, 7); // Lo, Hi, init, prior, prior_sd, prior_type, phase;
	k++;
	dtempvec = timevary_parm_rd[k](1, 7);
	dtempvec(3) = value ( selparm(isigmasel + a - amin) );
	report4 << dtempvec << " # sigma_sel for fleet:_" << tempvec(1) << "; " << anystring << "_" << a <<endl;
	}

.

The example attached includes input files (which runs successfully) and the control.ss_new file with the missing parameter line.
simple_small_2DAR_len.zip.

To Reproduce

Run the model attached above.

Expected behavior

Parameter line for 2D-AR selectivity

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

3.30.23.1

Additional Context

No response

[iantaylor-NOAA]

I forgot to credit @EJDick-NOAA for sharing a model that includes the setup replicated in the attached example where the r4ss function for reading the control file also fails to work with sigma_amax < 0.

[Rick-Methot-NOAA]

assignment accepted

[Rick-Methot-NOAA]

revised code produces in control.ss_new:

#_specs:  fleet, ymin, ymax, amin, amax, sigma_amax, use_rho, len1/age2, devphase, before_range, after_range
#_sigma_amax>amin means create sigma parm for each bin from min to sigma_amax; sigma_amax<0 means just one sigma parm is read and used for all bins
 3 2011 2022 5 15 -1 0 1 6 0 0  #  2D_AR specs for fleet: SURVEY2 LEN
 0.1 2 1 1 99 0 -3  # sigma_sel for fleet:_3; LEN_5
-9999  0 0 0 0 0 0 0 0 0 0 # terminator

[iantaylor-NOAA]

Looks good, thanks for working on this so quickly @Rick-Methot-NOAA