remove comperr check rel. Nfleet#404
Merged
Rick-Methot-NOAA merged 1 commit intomainfrom Feb 3, 2023
Merged
Conversation
This check on indexing for comperr is too prone to error and misinterpretation. It is unnecessary, so is removed from code.
iantaylor-NOAA
approved these changes
Feb 2, 2023
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
Looks good and works for the petrale example as you said.
I'm not sure why my attempted fix didn't work as well, perhaps I got something wrong in the if else combination. Doesn't matter now.
Rick-Methot-NOAA
deleted the
402-bug-partition-weighting-not-working-when-parmselect-nfleets
branch
Rick-Methot-NOAA
restored the
402-bug-partition-weighting-not-working-when-parmselect-nfleets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check on indexing for comperr is too prone to error and misinterpretation. It is unnecessary, so is removed from code.
resolves #402
Code now works with the Petrale example linked to the issue
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
none
Has any new code been documented?
no need. code was removed
If not, please add documentation before submitting the Pull Request.
is there an input change for users to Stock Synthesis?
If so, please provide an example of the new inputs needed.
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):
If changes are needed in the change log, please fill in the table here:
Additional information (optional):